search

chronosacaria / MCDungeonsArmors

Bringing the armours of Minecraft Dungeons to Minecraft
Other
22 stars 9 forks source link

[Bug Report]: "Burning" enchant applies fire to the mob before the player takes damage #64

Closed 7z99 closed 1 year ago

7z99 commented 1 year ago

Describe the bug; What happened?

In essence, when you are attacked by a mob while wearing armour with the burning enchant, the mob is set on fire before the damage is taken by the player, which means if you're attacked by a zombie for example, you'll be set on fire on the first attack if the difficulty is hard.

Expected Behavior

Instead of what is happening, I believe the mob should only be set on fire after the damage is taken by the player, they shouldn't be set on fire when the mob first hits them.

Mod Version

MC 1.19.2, MCDA 2.2.0, Fabric 0.14.10

Minecraft Launcher

CurseForge

Operating System

Windows

Modpack

No response

Additional context

Here's a video: (sorry was only able to upload on YouTube as the video is >10mb) https://www.youtube.com/watch?v=8LBCm9baxwE&ab_channel=7z99

I'm unsure as to whether or not this is actually a bug, but I believe the player should only be set on fire when they are attacked when the mob is already on fire (subsequent attacks). If it isn't a bug I guess this is a feature request.

chronosacaria commented 1 year ago

@7z99 Ah, I see what you mean. Thanks for catching that. We'll take a look at this

chronosacaria commented 1 year ago

It isn't a bug, but I see the benefit to it being the way that you're describing

7z99 commented 1 year ago

Ah okay, got you. Thanks!

Kluzzio commented 1 year ago

At this time, we have decided that this will not be changed.