chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
67 stars 27 forks source link

Dual Wield Spam #102

Closed TheSkeletonAppears closed 2 years ago

TheSkeletonAppears commented 2 years ago

Describe the bug This occurs when you have a dual wield weapon like The Beginning and The End if you hold down right click the weapon in the off hand slot will spam this is really bad with the enigma resonator

To Reproduce Steps to reproduce the behavior:

  1. Go get a dual wield weapon like The Beginning and The End
  2. Click on RMB
  3. Scroll down to '....'
  4. See error

Expected behavior It will spam non stop and the damage is not erm lets say the damage stays the same since the combat update you cant spam swords anymore well this breaks that rule

Screenshots If applicable, add screenshots to help explain your problem.

Please complete the following information:

Additional context Add any other context about the problem here.

Kluzzio commented 2 years ago

This is a known issue. Thank you for reporting it. We will be revisiting the entire dual wielding implementation so we will take this into account when doing so and hopefully be able to implement this feature.

Kluzzio commented 2 years ago

We are integrating Better Combat into MCDW for our 1.18 and our 1.19 branch. Part of this involves removing the dual wielding feature as it is now. We may re introduce it for if the user wishes not to have Better Combat in their mods. In the case that Better Combat is used though, the dual wielding will not be spammable.

Kluzzio commented 2 years ago

The fallback for Better Combat has working antispam so we gucci