chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
67 stars 26 forks source link

[Bug Report]: Swift Striker cannot be upgraded with Echo 2+ or Ambush 2+ #202

Closed Kluzzio closed 1 year ago

Kluzzio commented 1 year ago

Describe the bug; What happened?

The code in Enchantment Mixin does not work because it is overridden by canCombine as called in the AnvilScreenHandler. Therefore, the Swift Striker cannot be enchanted with echo or ambush in an anvil which is not intended.

Expected Behavior

Can enchant it with Echo or Ambush in Anvil.

Mod Version

Dev. Alternatively: 5.0.7

Minecraft Launcher

Vanilla

Operating System

Windows

Modpack

None

Additional context

We tested this and sadge. Must find way to cleanly bypass canCombine but the relevant method is an override and therefore cannot be the target of a mixin directly.