search

chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
67 stars 26 forks source link

Fix: Depend on MixinExtras properly. #216

Closed LlamaLad7 closed 1 year ago

LlamaLad7 commented 1 year ago

As mentioned in the release notes, you need to depend on MixinExtras differently since 0.2.0-beta.5. The MixinExtras jar included in your latest release is empty, causing https://github.com/LlamaLad7/MixinExtras/issues/28.

chronosacaria commented 1 year ago

@LlamaLad7 Ohhhhh. Wow I really derped on this one. Thanks for explaining this to me. I'll merge the pull request and get that fix taken care of. Thank you again!

LlamaLad7 commented 1 year ago

I forgot about that as well ^

chronosacaria commented 1 year ago

Hey, @LlamaLad7! I am running into some issues with the new version of Mixin Extras (at least, I think that's what happening). There is now a conflict with MemoryLeakFix and MCDW that is producing the following error: latest.log

We managed to chase down the issue being linked to this mixin in MemoryLeakFix, but I am not sure if this is something that is being caused by Mixin Extras or if this is something that either of us need to fix on our end. We don't touch the same methods in MCDW, so I am unsure of how it could be something that we're doing. If you could offer any insight, that would be amazing!

Thanks, in advance!

LlamaLad7 commented 1 year ago

Yep, my bad, fixed in beta 8. Sorry for the inconvenience, I broke something while fixing something else.

chronosacaria commented 1 year ago

@LlamaLad7 Ah, thank you, so much!