chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
67 stars 27 forks source link

[Bug Report]: [Fabric] MCDW Bow enchantments don't work on Botania Bows #223

Open pontorka opened 1 year ago

pontorka commented 1 year ago

Describe the bug; What happened?

I was trying to make a bow, and the enchantment didn't appear to work, so I hopped into creative and enchanted a crystal bow from botania with Enigma Resonator, Levitation Shot and Phantom Mark, but none worked. (I'm not sure if it is a MCDW or a Botania bug, since the Botania bows accept normal bow enchants and they work)

Botania-1.19.2-439-FABRIC mcdw-5.0.11-1.19 (I don't have it updated cuz it crashes with another mod)

Expected Behavior

Enchant Crystal Bow with levitation Shot 3 Target should Levitate, it doesn't Enchant Crystal Bow with phantom mark 3 Target should glow, it doesn't

Enchanted normal mc bow with both, both effects apply correctly

Mod Version

1.19.2

Minecraft Launcher

CurseForge

Operating System

Windows

Modpack

Custom

Additional context

No response

chronosacaria commented 1 year ago

@pontorka Could you upload your startup log, so that I can see if anything is loading oddly. Just make sure you remove any PII

chronosacaria commented 1 year ago

It is sounding like there might be an issue with how Botania is apply enchantments, but I'm not 100% sure

pontorka commented 1 year ago

@chronosacaria Where do I get that log? Just the latest.txt?

pontorka commented 1 year ago

latest - copia.log

chronosacaria commented 1 year ago

@pontorka Sorry for the delayed response. Yeah, that was perfect. Nothing seems to be loading oddly between MCDW and Botania. I'll take a deeper look into this. However, it is worth noting that there are some issues with AzureLib in your pack. May want to take a look into those

chronosacaria commented 1 year ago

Note to self: Class in Question from Botania -- https://github.com/VazkiiMods/Botania/blob/1.19.x/Xplat/src/main/java/vazkii/botania/common/item/equipment/tool/bow/LivingwoodBowItem.java

pontorka commented 1 year ago

@pontorka Sorry for the delayed response. Yeah, that was perfect. Nothing seems to be loading oddly between MCDW and Botania. I'll take a deeper look into this. However, it is worth noting that there are some issues with AzureLib in your pack. May want to take a look into those

I have no clue how to fix those errors. There's plenty of other errors like models not found and similar. Whatever the case, thank you for reaching out. Do you think I should post the issue in Botania's Git as well?

pontorka commented 1 year ago

@chronosacaria Update:

I updated MCDW since I fixed the compat issue with the other mod, and now, it works with Livingwood Bow, but it still doesn't work with the Crystal Bow