search

chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
66 stars 25 forks source link

[Feature Request]: Pain Cycle Settings Idea #224

Closed SlashXRed closed 1 year ago

SlashXRed commented 1 year ago

Is your feature request related to a problem? Please describe.

Firstly, I know theres a similar problem, but the solution provided veered off onto a different question they had,

So, I'm using a mod similar to Dark Enchanting Table, the point is that it can basically force enchantments onto weapons. My problem is that I constantly get hurt after I use a Pain Cycle weapon, when I feel that there should at least be an option to make it only when you strike an opponent.

One response saying that this is how it should be was to discourage swapping weapons from something that has Pain Cycle, but no weapons currently have pain cycle without forcing enchants like that?

Describe the solution you'd like

I would like for there to be a setting or toggle to disable the Damage Over Time effect of Pain Cycle, and make it only when you hit an opponent.

Describe alternatives you've considered

No response

Additional context

I'm using the simply swords mod. specifically enchanting the Netherite Scythe with Pain Cycle III. I enchanted it like this due to using the Enchanting Infuser mod. I've also done it on the vanilla Netherite Sword and a Soul Scythe (maybe it just really wanted a MC Dungeons weapon but nope), and the Damage Over Time happened over and over.

SlashXRed commented 1 year ago

Just from a guess, I think line 209 in MCDungeonsWeapons/src/main/java/chronosacaria/mcdw/effects/EnchantmentEffects.java does the damage over time, is that the part that should get toggled?

SlashXRed commented 1 year ago

Im currently using 1.19.2, so is it possible to make the solution like a patch? I dont know how patches work though

SlashXRed commented 1 year ago

Sorry, but I just came up with an alternative, and that's to make the pain cycle stop at a certain point? Im going to close this just becuase I think I can make a minor patch to suit what I want, I know a little bit of how to work with stuff like this, sorry for the bother of reading this in advance.