search

chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
66 stars 25 forks source link

remake refreshment enchantment #235

Closed solaluset closed 11 months ago

solaluset commented 11 months ago

This PR remakes implementation of refreshment enchantment to make it properly work with enchantment levels more than 1 and to make filling mechanic more similar to how vanilla bottles work when you fill them with water.

This is how it worked before:

Preparation (the sword is with Refreshment III) before1 After the kill (bottles "jump" to other slots, which is weird) before2 After player drinks the bottle (other two just disappear) before3

This is how it works now:

Preparation after1 After the kill (bottles are filled in-place) after2 After player drinks the bottle after3

solaluset commented 11 months ago

It also fixes #222 by ignoring the offhand completely (let me know if that's not acceptable)

chronosacaria commented 11 months ago

@Krutyi-4el This looks great! The thing is, though: we need to consider the offhand since that is a slot where some users might have bottles in. Also, 1.18 is no longer supported, so, if you can resubmit your PR for the 1.20 branch, we can consider this in a way that will actually impact users.

Since this PR is for an unsupported version, I'm going to Close it with this comment, but this doesn't mean that we aren't interested in the PR. We just would like to see it for the latest version and if you make the PR, we can show you as a Contributor for your efforts. If you'd rather us just update the PR that you've submitted, manually, just let us know; but, keep in mind, you'd not be noted as a Contributor because of how GitHub handles it because it is a completely automated process

solaluset commented 11 months ago

It's a pity that 1.18 isn't supported 😥 I'll add offhand support and open a PR to 1.20 then