search

chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
66 stars 25 forks source link

[Bug Report]: Broken Sawblade can be enchanted with unbreaking (this should not be possible) #237

Closed SomeFellaUnknown closed 9 months ago

SomeFellaUnknown commented 11 months ago

Describe the bug; What happened?

you are not prevented from enchanting an broken sawblade with unbreaking in an enchanting table, and you are not prevented from applying unbreaking to an broken sawblade or mechanized sawblade via an anvil. I cannot for the life of me find a single situation where the intended behaviour for the broken sawblade is applicable

Expected Behavior

the changelog claims that these items are meant to be incompatible with unbreaking, and the code seems to imply they are meant to be incompatible with unbreaking

Mod Version

8.0.3

Minecraft Launcher

Vanilla

Operating System

Windows

Modpack

mcdw + required dependencies, 1.20.1

Additional context

also did not happen in 8.0.0

chronosacaria commented 11 months ago

@SomeFellaUnknown Thanks for catching this! I wonder if something changed from when I did the testing and got this working inDev and when it was released. I'll look into this on Monday! :)