chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
67 stars 26 forks source link

[Bug Report]: Some (Two handed?) MCD Weapons delete anything in the off hand #241

Closed finnglink closed 1 year ago

finnglink commented 1 year ago

Describe the bug; What happened?

Tested with Torches, Bread and a Shield, and the Vicious Hawkbrand and the Anchor. As soon as I select the hotbar slot the weapon is in, the off hand is cleared and its contents deleted.

Expected Behavior

Don't :D

Mod Version

8.0.3

Minecraft Launcher

Other

Operating System

MacOS

Modpack

Custom Fabric Modpack

Additional context

No response

finnglink commented 1 year ago

Other Combat/Player related mods I have installed:

chronosacaria commented 1 year ago

@finnglink Just making sure: is it deleted or you can't see it? Better Combat makes the Hawkbrand a two handed sword, which hides the item in your offhand whilst it is equipped. Upon unequipping the Hawkbrand, those items should return

finnglink commented 1 year ago

@chronosacaria that's what I thought, but they're gone completely. The don't jump to another slot / stack, and once I go back to a different hotbar slot, it's just empty.

chronosacaria commented 1 year ago

Okay. This sounds like it might be an issue with Better Combat and another mod because it doesn't happen with just MCDW. I'd encourage you to open an issue on the Better Combat GitHub, as well. I'll leave this open until I can touch base with Daedelus

chronosacaria commented 1 year ago

Thanks for responding so quickly, btw

finnglink commented 1 year ago

Thanks! It has only occurred to me so far with MCDW, but I'll check with simply swords, some of those should be two handed as well. And I'll open an issue over at Better Combat.

chronosacaria commented 1 year ago

@finnglink So it turns out that this is caused by a conflict between Origins and Better Combat. From what I understand, there is a fix in the works. Since this isn't related to MCDW, I'm gonna close this issue. Thanks for mentioning it, though!