chronosacaria / MCDungeonsWeapons

Bringing the weapons and tools of Minecraft Dungeons to Minecraft
Other
67 stars 26 forks source link

Updated to 1.20.4 #269

Open VoidXWalker opened 6 months ago

VoidXWalker commented 6 months ago

Updated MCDungeonWeapons to Minecraft 1.20.4. Testing suggests that the port works as intended. Running this port requires an, at the time this pull requested is being opened, unofficial 1.20.4 build of Better Combat: https://github.com/ZsoltMolnarrr/BetterCombat/pull/332

chronosacaria commented 5 months ago

Hey, @VoidXWalker! Thank you, so much, for this PR. Unfortunately, MCDW is in the middle of a refactor. I can let you know when that is done and, if you're able, would you be willing to update your PR? Since 1.20.4 is not compatible with 1.20.1, making the PR as a separate branch would be preferable

EchoEllet commented 5 months ago

The PR I sent has one bug, I believe it's when you ride or interact with the horse, I didn't test it or saw any bugs but it's in the code changes