Add a form to create a PoliticalEntity

chronoscio / frontend

Frontend repository for the ChronoScio project

https://chronoscio.now.sh

GNU General Public License v3.0

3 stars 0 forks source link

Add a form to create a PoliticalEntity #20

Closed amaury1093 closed 5 years ago

amaury1093 commented 5 years ago

~Not quite finished yet, still has wikipedia_link instead of links, waiting for https://github.com/chronoscio/backend/pull/30~ Added links field.
Not wired up to the backend. On submit, check console to see the result.
Cannot input Diplomatic Relation yet, left for another PR.

Closes #14.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

quorth0n commented 5 years ago

Will #19 be addressed in a separate PR?

amaury1093 commented 5 years ago

I'll address #19 in a separate PR, this one is already big enough.

On your screenshot, my guess is that the reference is more than 150 chars. But the fact that it doesn't show an error popup is a bug, I'll fix that in this PR.

amaury1093 commented 5 years ago

In the latest 3 commits, I created an ui package, where I put all common UI elements used across the app. Might be easier to browse https://github.com/chronoscio/frontend/tree/am-input/packages instead of looking at file diffs. There are no code changes in the last 3 commits.

quorth0n commented 5 years ago

^approving in advance as I suspect this will be an easy/quick fix.

amaury1093 commented 5 years ago

@whirish Ah ok, didn't have this problem on my opera or firefox. Should be fixed now, I'll let you merge.