search

chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
229 stars 55 forks source link

Disable default features in chrono-tz-build #104

Closed lopopolo closed 1 year ago

lopopolo commented 1 year ago

Fixes #103.

lopopolo commented 1 year ago

I know this is a small change, but I'd very much appreciate it if this could be included in a patch release soon if it is accepted.

This will help prune some dependencies from my lockfile.

djc commented 1 year ago

Does this change cause semver-incompatible API changes?

lopopolo commented 1 year ago

I am not sure. The uncased feature in chrono-tz still requires a feature. I'm not sure what the implications are for that feature in the build script.

lopopolo commented 1 year ago

It looks like the build crate still emits the cfg directives so this change should not result in any new APIs becoming available.

djc commented 1 year ago

I don't see how this changes anything, since chrono-tz-build doesn't enable any features by default as far as I can see?

lopopolo commented 1 year ago

Ahh I think you're right. Maybe it was the reshuffling of the phf features that fixed things up