search

chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
229 stars 55 forks source link

tzdb 2022b was released today #106

Closed Kijewski closed 3 months ago

Kijewski commented 1 year ago

Some tests are failing after updating the tz submodule to https://github.com/eggert/tz/commit/b61a7acb4d267872f1c5319f30889a927b441b8f, because more pre-1970 information was removed. The announcement mentions that you can use make PACKRATDATA=backzone PACKRATLIST=zone.tab to keep the pre-1970 information, but I am not sure if you want that, or how to replicate this command with the build system.

djc commented 1 year ago

Thanks, I saw the announcement. I guess we should probably not keep the pre-1970 data by default? Can you put up a PR so I can more easily look at the failing tests?

Kijewski commented 1 year ago

Including the data pulls in 49,344 extra bytes. (372,099 kB vs 322,755 kB; measured in tzdb's built, as I don't know how to include the backdata in here.)

Well, I guess 99% of the users wouldn't even need any pre-2010 data. :) But maybe the remaining 1% might benefit from the 50 kB or 13% extra bytes to include the pre-1970. Maybe the choice could be feature guarded?