chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
229 stars 55 forks source link

Move check crates into workspace #109

Closed djc closed 3 months ago

pitdicker commented 3 months ago

@djc Is this a change you would still want? I could pick it up.

djc commented 3 months ago

Yes, would be nice to have this, thanks!

pitdicker commented 3 months ago

No clue yet what to do with this error:

error[E0152]: found duplicate lang item `panic_impl`
  --> check-nostd/src/main.rs:10:1
   |
10 | / fn catch_panic(_e: &PanicInfo) -> ! {
11 | |     loop {}
12 | | }
   | |_^
   |
   = note: the lang item is first defined in crate `std` (which `chrono_tz` depends on)
   = note: first definition in `std` loaded from /home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-6e3078511c661ac3.rlib
   = note: second definition in the local crate (`check_nostd`)

For more information about this error, try `rustc --explain E0152`.
error: could not compile `check-nostd` (bin "check-nostd") due to 1 previous error
Error: Process completed with exit code 101.
pitdicker commented 3 months ago

Because a workspace has a single Cargo.lock every crate gets the union of all features. So we can't move check-nostd to the workspace.

Also we can't easily do cargo test for check-regex-filtering because it requires the environment variable CHRONO_TZ_TIMEZONE_FILTER="(Europe/London|GMT)".

It seems this is not going to work?

djc commented 3 months ago

Okay, let's close this then.