Turn `ParseError` into a real error

chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database

Other

229 stars 55 forks source link

Closed laralove143 closed 3 months ago

laralove143 commented 1 year ago

Currently it's just a String, this is unidiomatic for various reasons:

It doesn't implement std::error::Error, meaning ? or any kind of error coercion isn't possible (i.e with anyhow)
It doesn't give enough info on what the error is going to be, the documentation could give this info but that's not ideal
It's an unexpected API
It might be unnecessary allocation (converting an error to string isn't always necessary)
It doesn't allow polymorphism or fields

djc commented 1 year ago

Sounds reasonable, I'd be happy to review a PR in this direction!

pitdicker commented 3 months ago

Fixed in #161.