Closed westy92 closed 8 months ago
I added a test, but I also verified I can use this locally when pointing cargo at my branch:
chrono-tz = { git = "https://github.com/westy92/chrono-tz.git", branch = "expose-tzdb-version" }
assert_eq!("2023c", chrono_tz::IANA_TZDB_VERSION);
We just have to remember to update this value when we bump the version.
I don't want something that's updated manually. There should be something in place to handle this for us. We're already doing codegen, so it seems like this shouldn't be too hard?
This is now fully detecting the version via codegen just like tz
itself does - by using git describe
(https://github.com/eggert/tz/blob/main/Makefile#L632).
@djc all PR comments have been addressed. 👍
I'm open to merging this at this point, but it would need to pass CI... Sorry this is taking so long!
This is passing locally on my Mac - I'm trying to track down why CI is failing. Could you please rerun the macOS build to see if it passes? It is getting canceled due to the other failure.
I don't think I can rerun the macOS job only?
If you navigate to the job, you can re-run just one.
it fails on macOS as well.
@djc CI is green 🎉
Done ✅
Thanks for sticking with it! I'll see if I can get this published shortly.
You're welcome. Thank you for the review and publishing. 🙌
Fixes #131. 🚀