chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
228 stars 55 forks source link

Expose IANA_TZDB_VERSION #136

Closed westy92 closed 8 months ago

westy92 commented 11 months ago

Fixes #131. 🚀

westy92 commented 11 months ago

I added a test, but I also verified I can use this locally when pointing cargo at my branch:

chrono-tz = { git = "https://github.com/westy92/chrono-tz.git", branch = "expose-tzdb-version" }
assert_eq!("2023c", chrono_tz::IANA_TZDB_VERSION);
djc commented 11 months ago

We just have to remember to update this value when we bump the version.

I don't want something that's updated manually. There should be something in place to handle this for us. We're already doing codegen, so it seems like this shouldn't be too hard?

westy92 commented 9 months ago

This is now fully detecting the version via codegen just like tz itself does - by using git describe (https://github.com/eggert/tz/blob/main/Makefile#L632).

westy92 commented 9 months ago

@djc all PR comments have been addressed. 👍

djc commented 9 months ago

I'm open to merging this at this point, but it would need to pass CI... Sorry this is taking so long!

westy92 commented 9 months ago

This is passing locally on my Mac - I'm trying to track down why CI is failing. Could you please rerun the macOS build to see if it passes? It is getting canceled due to the other failure.

djc commented 9 months ago

I don't think I can rerun the macOS job only?

westy92 commented 8 months ago

If you navigate to the job, you can re-run just one.

image
djc commented 8 months ago

it fails on macOS as well.

westy92 commented 8 months ago

@djc CI is green 🎉

westy92 commented 8 months ago

Done ✅

djc commented 8 months ago

Thanks for sticking with it! I'll see if I can get this published shortly.

westy92 commented 8 months ago

You're welcome. Thank you for the review and publishing. 🙌