search

chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
228 stars 55 forks source link

impl Default for Tz must be declared public #150

Closed rxdiscovery closed 3 months ago

rxdiscovery commented 3 months ago

Hello,

I have a small remark :

impl Default for Tz {
    fn default() -> Self {
       Tz::UTC
    }
}

must be declared public, "pub impl"

djc commented 3 months ago

Pretty sure impls don't have associated privacy, and you didn't explain why you want this.

rxdiscovery commented 3 months ago

@djc you're absolutely right, sorry it was a bug with my ide and rust-analyzer :+1: