search

chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
235 stars 56 forks source link

Make `ParseError` a real `Error` enum #161

Closed pitdicker closed 6 months ago

pitdicker commented 6 months ago

To continue #122 by @laralove143.

I added a second error type that is used when deserializing, which can borrow the input string and print a nice message (without needing to allocate).

Fixes @121.

pitdicker commented 6 months ago

Interesting. The new CI test with cargo publish doesn't like it if the version of chrono-tz-build is changed. Because it is not yet released, testing the package of chrono-tz fails. Not sure yet what to do.

pitdicker commented 6 months ago

Found a workaround: package without verification, extract to a directory with vendored crates, verify against vendored instead of crates.io. Thanks to https://github.com/rust-lang/cargo/issues/1169#issuecomment-1254260875.

pitdicker commented 6 months ago

I'll wait with merging to make #162 part of the new versions.

pitdicker commented 6 months ago

Published :tada:.