search

chronotope / chrono-tz

TimeZone implementations for rust-chrono from the IANA database
Other
235 stars 56 forks source link

Merge parse-zoneinfo into chrono-tz workspace #166

Closed djc closed 5 months ago

pitdicker commented 5 months ago

Do you plan to delete/archive the parse-zoneinfo repo?

djc commented 5 months ago

Yes, after replacing the README with a pointer to chrono-tz. Sound good?

IMO the main advantage is that we get to directly test usage in the chrono-tz builder, which is probably the primary use case.

pitdicker commented 5 months ago

Yes, no better way to test parse-zoneinfo than the be part of a repository with the time zone database and a crate that uses it.

pitdicker commented 5 months ago

Best to merge manually?

djc commented 5 months ago

Yeah, was doing that when I noticed that the merge commit did not have the current main as its parent (but an earlier commit), so doing another CI run to make sure I've recreated the merge commit correctly.