chronotope / chrono

Date and time library for Rust
Other
3.3k stars 523 forks source link

Convert `NaiveDate::from_num_days_from_ce` to return `Result` #1470

Closed Zomtir closed 7 months ago

Zomtir commented 7 months ago

This pull request targets the issue #1469. The implementation is based on the discussion in #1445.

cc @pitdicker

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.34%. Comparing base (999582e) to head (bd44d85).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.5.x #1470 +/- ## ========================================== - Coverage 94.34% 94.34% -0.01% ========================================== Files 37 37 Lines 17009 17007 -2 ========================================== - Hits 16047 16045 -2 Misses 962 962 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pitdicker commented 7 months ago

It may be for the best that you didn't start with the timestamp methods on NaiveDateTime #1471.

pitdicker commented 7 months ago

Your first one in :tada:.