search

chronotope / chrono

Date and time library for Rust
Other
3.3k stars 523 forks source link

Remove `with_*0` methods #1521

Closed pitdicker closed 6 months ago

pitdicker commented 6 months ago

The with_month0, with_day0 and with_ordinal0 methods where moved from the Datelike trait to the types in #1490 and partially converted to return Results in #1509.

But looking at it again I don't feel they carry their weight to keep around.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.97%. Comparing base (d286f93) to head (ea83e30).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.5.x #1521 +/- ## ========================================== - Coverage 94.01% 93.97% -0.04% ========================================== Files 37 37 Lines 16830 16725 -105 ========================================== - Hits 15823 15718 -105 Misses 1007 1007 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.