Closed pitdicker closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.82%. Comparing base (
ca3c3b6
) to head (19dd217
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Published.
I'll look through the rust issue tracker if there is anything about type aliases for enums.
In #1501 I thought renaming
LocalResult
toMappedLocalTime
would be entirely without consequences as long as there is a type alias with the old name. Turns out there is one case where a type alias behaves differently :disappointed:. You can't import enum variants from a type alias withuse chrono::LocalResult::*
.We have two choices:
LocalResult
, and use the type alias everywhere else.The second choice has my preference. The docs look mostly sane, but break down once you come to the trait implementations section:
...