Closed pitdicker closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.01%. Comparing base (
08c9792
) to head (bb658ae
). Report is 5 commits behind head on 0.5.x.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
For 0.5 I'd like to make the
Month
enum less useless.By defining
Month::January
as 1 users can do simple casting, and use it for example in:We can also choose to make
Datelike::month
returnMonth
(#727). I didn't do so here for two reasons:year()
andday()
also return integers. I find working with integers more convenient than wordy month names.month
method onNaiveDate
that can't be optimized out without unsafe code. We knowMdf::from_ol(/* ... */).month()
will reaturn a value in1..=12
, but the compiler doesn't.