Closed pitdicker closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.99%. Comparing base (
58ae538
) to head (87f8b43
). Report is 1 commits behind head on 0.5.x.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Also updated the description in lib.rs
and the readme, and removed the __unstable_bench
feature.
The bench feature was only used for benchmarking YearFlags::from_year
. All that method does is:
let year = year.rem_euclid(400);
YEAR_TO_FLAGS[year as usize]
A division and a table lookup doesn't seem all that interesting to benchmark, let alone have a feature for.
Much better, I think that split was definitely worth it!
Sorry that this is taking so many back-and-fort between us. But I'm really starting to like the changes here as good cleanups.
Remove the old crate features
libc
,old_time
,rkyv
andwinapi
. Switch to thedep:
syntax for optional dependencies that where exposed as features:pure-rust-locales
,android-tzdata
,iana-time-zone
,js-sys
,wasm-bindgen
andwindows-targets
.