Closed blacktiago closed 4 years ago
Any chance this can be merged? Maybe to another branch not master?
Thank you for solving the issue! I had to add this piece of code manually because this has not been merged yet, so I hope this PR gets approved soon.
@blacktiago I noticed that when changing the flag's width and height (like phoneNumberTextField.flagSize = CGSize(width: 48, height: 48)
) it does not update the UI. Could you update the PR's branch to handle this case?
I've tested this solution real quick. Sometimes when the text field is tapped the keyboard does not appear.
This shouldn't be merged yet. I'm testing with an iPhone X, inside a tableViewCell and it doesn't solve the issue.
There is a problem with this solution. When you input the whole phone number, the left view increases its width. Then, if you end editing the text field and tap it to edit again, the left view captures the touch and the text field does not become the first responder. I was able to notice this using Debug View Hierarchy.
Still, I am using a modified version of this PR's code while a real solution is not provided.
Can you test with the fix_layout
branch ?
@pauloec @thiagocesarm I could try to fix it this weekend but I really need you to add a little xCode project with the issue on it. Thanks
@grifas Hey, it works, thank you!
Could you guys add a little more space between the country code and the phone number?
checked fix_layout and seems to be working fine. Thanks!
…b.com/chronotruck/FlagPhoneNumber/issues/112