FBE::FBEBuffer invalid default move constructor and move assignment operator - they lead to double freeing memory

chronoxor / FastBinaryEncoding

Fast Binary Encoding is ultra fast and universal serialization solution for C++, C#, Go, Java, JavaScript, Kotlin, Python, Ruby, Swift

https://chronoxor.github.io/FastBinaryEncoding

MIT License

827 stars 86 forks source link

FBE::FBEBuffer invalid default move constructor and move assignment operator - they lead to double freeing memory #39

Closed herolover closed 3 years ago

herolover commented 3 years ago

Using move semantics for FBE::FBEBuffer can lead to undefined behavior because _capacity remains non-zero and in destructor memory will free twice or even more times.

chronoxor commented 3 years ago

I've just delete move semantic operators as they are not used much in FBE