search

chronoxor / FastBinaryEncoding

Fast Binary Encoding is ultra fast and universal serialization solution for C++, C#, Go, Java, JavaScript, Kotlin, Python, Ruby, Swift
https://chronoxor.github.io/FastBinaryEncoding
MIT License
817 stars 85 forks source link

Javascript Client Request Issue #66

Open jbspears opened 2 years ago

jbspears commented 2 years ago

Looks like the client _requests_by_id and _requests_by_timestamp are Map objects and should use set/get. Also, the timeout passed to the request method is multiplied by 1000000. I would think since the timestamp is milliseconds and the timeout is milliseconds that no conversion would be needed. Once I modified the Map objects to use set/get and removed the timeout multiplier, the client request seemed to work as expected. Thanks.

chronoxor commented 2 years ago

Will look into this issue! Thanks for reporting!

chronoxor commented 2 years ago

Fixed! Thanks for reporting! Can you please check the fix on your side?