chrsep / Kingfish

Portal for Binusmaya v0.3 and up
http://goo.gl/oqjjUE
GNU General Public License v3.0
26 stars 10 forks source link

Resource file issue & suggestion #29

Open Joonath opened 7 years ago

Joonath commented 7 years ago

The downloaded file seems to be broken (error message: invalid format or file extension). Have you not implementing any extension changes? (or perhaps there is something missing regarding to keeping the file extension as it is) Currently tested on English for Business Presentation Meeting 1 file for Binusian 2021

Also I have some suggestion to Resource file managing. It seems that I couldn't find where the downloaded Resouce is being stored, and might be a good idea to have some additional features to this (e.g Delete/Move downloaded file through Portal apps)

chrsep commented 7 years ago

@Joonath I haven't got time to checked the resources API from Binusmaya. The last time i checked, there was some inconsistencies on the data that it returned, it was a bit messy so i don't actually really understand how everything work, so I don't consider the current implementation to get and save the data as robust. It definitely can be improved.

The files is currently being downloaded by your phone default download manager, it should be saved into your phone's download location the same way your browser saved downloaded things. I haven't got time to implement a custom downloader that controls the location and existence of the resources files yet. But i do thinks that would be a good idea to add.