search

chrsep / Kingfish

Portal for Binusmaya v0.3 and up
http://goo.gl/oqjjUE
GNU General Public License v3.0
26 stars 10 forks source link

grades error #42

Open ageliusg opened 6 years ago

ageliusg commented 6 years ago

grades calculation error

chrsep commented 6 years ago

Hi @ageliusg , how does the error look like? Can you provide more detail?

cviali commented 5 years ago

I have no idea what's wrong with the grades calculations, but I realized there's a problem with the Final Multipapers textViews where the textViews are not completely GONE'd (I don't know what does it called, in java you delete a view by calling GONE) and it still shows up with the same grades and scores from the previous shown courses.

some context: (please pretend the scores aren't there, I'm on mobile and currently not able to reach my laptop because it's on RMA process.)

screenshot 1: screenshot1 this screenshot shows the problem I mentioned, note that the course Entrepreneurship II have Final Multipaper I and II, I haven't done my finals yet so the results are N/A, but you get the point.

screenshot 2: screenshot2 here's the actual screenshot of the problem, note that course Game Design doesn't have neither Final Multipaper I or II, but the view failed to delete the Final Multipaper textView, along with previous shown scores (Entrepreneurship II).

I haven't checked how Portal does the course grading, either by pulling it out directly from Bimay, or doing the calculations on the native app, where the second option could results in wrong grade score result.

Might've aswell open a new issue for this but this could be the issue @ageliusg are referring.

senacand commented 5 years ago

@cviali Seems like you forgot to set the link to public. Can you set the link to public so I can see the problem?

cviali commented 5 years ago

@senacand whoops, my bad, I've edited it out to public.