chrsmithdemos / html5rocks

Automatically exported from code.google.com/p/html5rocks
0 stars 0 forks source link

Adding "tag:" to each tag in location.hash to prevent conflict with any anchor names or element ids. #818

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The issue with using just tag names in hash like "#gaming" would cause the page 
to scroll down to the bottom immediately. This behaviour is browser default. 
Even though we can get it fixed by scroll up to top after the page loaded, the 
UX will be bad cause there're two unexpected scrolls (down and up).

It was first reported in issue 793 
(http://code.google.com/p/html5rocks/issues/detail?id=793).

This change will require all links on other page to be modified into the new 
format. Would you please let me know if you see any page with links to the 
tutorials page with specific hash?

Original issue reported on code.google.com by han...@google.com on 14 Feb 2012 at 4:59

GoogleCodeExporter commented 9 years ago

Original comment by han...@google.com on 14 Feb 2012 at 5:01

GoogleCodeExporter commented 9 years ago
Cuz we have already removed the page grid are from the codebase (refer to issue 
825), the original issue(issue 793) to trigger the unexpected scrolling-down is 
temporarily subdued. But if we have any element ids shares the same string as 
one of the tag, this issue may appear again.

Original comment by han...@google.com on 6 Mar 2012 at 7:01