search

chrsmithdemos / html5rocks

Automatically exported from code.google.com/p/html5rocks
0 stars 0 forks source link

Review: aec9318c31cd #825

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Link to revision:
http://code.google.com/p/html5rocks/source/detail?r=aec9318c31cda7c82104d8f9688d
0e8e59e867ea

Purpose of code changes:
I didn't see where we leverage the "Page grid" part of code. And this part of 
code could bring some unexpected page scrolling when we use "gaming", "mobile" 
or "business" as hash string in URL.

Original issue reported on code.google.com by han...@google.com on 15 Feb 2012 at 9:20

GoogleCodeExporter commented 9 years ago 
I believe that all of the 'page grid' scrolling has been taken out of the site, 
so we can probably safely remove those placeholder `DIV`s entirely.

Original comment by matthewm...@gmail.com on 15 Feb 2012 at 10:02

GoogleCodeExporter commented 9 years ago 
Thanks Matthew for the confirmation.
Done in Revision 113e07cbe89a.

Original comment by han...@google.com on 16 Feb 2012 at 9:29

GoogleCodeExporter commented 9 years ago

Original comment by ericbide...@html5rocks.com on 2 Mar 2012 at 6:54