search

chrthomsen / pygrametl

Official repository for pygrametl - ETL programming in Python
http://pygrametl.org
BSD 2-Clause "Simplified" License
289 stars 41 forks source link

The _before_lookup statement of BatchFactTable will cause batch loading to fail and reduce efficiency #26

Closed qianxuanyon closed 3 years ago

qianxuanyon commented 4 years ago

Hello

Whether the self.__insertnow() statement should not be executed in the _before_lookup method of BatchFactTable will cause batch loading to fail

chrthomsen commented 3 years ago

Hello,

We have to to call __insertnow() to make sure that all data is loaded before we try to do a lookup. Otherwise, the lookup would not find an inserted row if the row has not been loaded into the DB yet.

Please reopen and provide an illustrative example if you think there is something wrong in this.

Best regards, Christian Thomsen