Corrected 2 errors in datespan function

chrthomsen / pygrametl

Official repository for pygrametl - ETL programming in Python

http://pygrametl.org

BSD 2-Clause "Simplified" License

289 stars 41 forks source link

Corrected 2 errors in datespan function #37

Closed ssrika17 closed 3 years ago

ssrika17 commented 3 years ago

Error 1: The function did not check whether 'fromdate' and 'todate' are strings before calling .split Error 2: The function used dict.iteritems() which is not supported in Python 3.

skejserjensen commented 3 years ago

The changes look fine to me, but please add a line to CHANGELOG.rst - Version 2.7 (unreleased) - Fixed that documents the changes.

ssrika17 commented 3 years ago

I have now added a line about the fix to the changelog