Closed fromm1990 closed 1 year ago
@fromm1990 and @chrthomsen is this issue still relevant after #49 has been merged or can it be close?
@skejserjensen I think it depends on what the issue page should reflect. As I see it, there are two options:
If 1 is preferred, the issue should be closed. If 2, then a release should be pushed out before closing this issue. What do you prefer @skejserjensen and @chrthomsen?
I think an issue should be closed if a fix has been pushed to master. So I would say this issue should be closed now. Do you agree?
@chrthomsen the only drawback I can think of with that approach, is that people using the version from PyPI would discover the bug and then start a new issue unaware of the code base no longer having this issue.
Fixed in #49.
Hi, it has been discovered that the attributes
all
,keyrefs
, andmeasures
are missing from the BulkFactTable class. These attributes are expected to exist by the FactTablePartitioner class. The following code should raise an AttributeError exception.