search

chrusty / protoc-gen-jsonschema

Protobuf to JSON-Schema compiler
Apache License 2.0
496 stars 101 forks source link

Treating google.protobuf.ListValue as an array #145

Closed chrusty closed 1 year ago

chrusty commented 1 year ago

This relates to issue https://github.com/chrusty/protoc-gen-jsonschema/issues/143.

Added google.protobuf.ListValue as one of the specially handled Google types.

oliver commented 1 year ago

Did some testing; it looks like the ListValue name must be added to the wellKnownTypes map in internal/converter/types.go. I added those changes in https://github.com/oliver/protoc-gen-jsonschema/tree/issue_143/repeated_google_listvalue . Do you want to pick those changes to this pull request; or should I open a new PR?

chrusty commented 1 year ago

Thank you @oliver. I've taken your changes into the PR. I'll give you a shout in the release notes!