search

chrusty / protoc-gen-jsonschema

Protobuf to JSON-Schema compiler
Apache License 2.0
496 stars 101 forks source link

adding keep new lines as parameter #179

Open tzahush opened 9 months ago

tzahush commented 9 months ago

I would like to add the option to keep new lines as a flag

tzahush commented 9 months ago

@chrusty Do you think it is possible to get a review for this? Super simple PR which will be great to get merged

chrusty commented 9 months ago

@chrusty Do you think it is possible to get a review for this? Super simple PR which will be great to get merged

Hi @tzahush. I'm not sure this PR actually does anything in its current state - it appears to just set a flag!

tzahush commented 9 months ago

@chrusty today all flags can be set using CLI except for this flag, since we are using the CLI it'll be very helpful to be able to align it so all flags can be set with CLI.

tzahush commented 9 months ago

@chrusty any update? The main purpose is for people (specifically my team in this case :) ) to be able to use this flag that is already set in the system using the CLI.