search

chrusty / protoc-gen-jsonschema

Protobuf to JSON-Schema compiler
Apache License 2.0
496 stars 101 forks source link

int64 should always be string #48

Closed chrusty closed 4 years ago

chrusty commented 4 years ago

OneOf was causing issues for some users, and it was an exception only in place for int64. So now they will be represented as a string, unless the disallow_bigints_as_strings option is used.

Note: OneOf will still be used if the allow_null_values option is enabled.

chrusty commented 4 years ago

@grant how does this look to you? It might break a few eggs but I agree it seems like the right thing to do, given that we have options to override this behaviour for those that don't like it.