search

chrusty / protoc-gen-jsonschema

Protobuf to JSON-Schema compiler
Apache License 2.0
496 stars 101 forks source link

Duplicated sample step in Makefile #94

Closed Yowgf closed 3 years ago

Yowgf commented 3 years ago

Hi, it looks like the lines below (currently 58 and 59) are repeated in the Makefile, except for the echo command on the end.

@PATH=./bin:$$PATH; protoc --jsonschema_out=jsonschemas -I. --proto_path=${PROTO_PATH {PROTO_PATH}/OptionRequiredMessage.proto || echo "No messages found (OptionRequiredMessage.proto)"

@PATH=./bin:$$PATH; protoc --jsonschema_out=jsonschemas -I. --proto_path=${PROTO_PATH} ${PROTO_PATH}/OptionRequiredMessage.proto || echo "No messages found (Proto3Required.proto)"

chrusty commented 3 years ago

Hi @Yowgf, thanks for picking this up. I've been doing a bit of work lately around introducing proto options, and this thing you've found is a result of me renaming some files to group the options test protos together.

I've removed the duplicate line in this commit.

I won't tag a release with this, but they'll make it into the next one.

And thanks for your interest in the project!