search

chrusty / protoc-gen-jsonschema

Protobuf to JSON-Schema compiler
Apache License 2.0
496 stars 101 forks source link

Misspelling of "extension" #95

Closed Yowgf closed 3 years ago

Yowgf commented 3 years ago

I believe the word "extention", used throughout the repository, is a misspelling of "extension". I found this out when trying the "file_extention" option. It took me a few minutes to realize that it was written that way.

Thanks for this repository, by the way. Really useful!

chrusty commented 3 years ago

Hi @Yowgf. After getting over my initial offense, it appears that you may be correct on the spelling issue.

The one place it will cause issues is with the protobuf field, but I guess its a relatively new feature so should be OK to change.

Thanks for pointing this out. I'll release a new version soon with this fix.

Yowgf commented 3 years ago

Hi @chrusty. I am sorry, I really didn't mean to offend. I just hoped you might find the suggestion useful in some way. The reason I was so direct to the point was to avoid wasting your time reading through a long issue.

Again, thanks a bunch for the project! It has really helped me out recently.

chrusty commented 3 years ago

Hahahaha not at all, I'm always genuinely grateful for the feedback.

I'll fix it up, just busy with work-work today.

chrusty commented 3 years ago

Hey @Yowgf, I've fixed this up and made a new release here: https://github.com/chrusty/protoc-gen-jsonschema/releases/tag/1.3.1

Thanks again for your interest in the project!