Closed maxsimych closed 4 months ago
Hello @chrvadala,
Any chances to have this PR reviewed and possibly merged into your repo?
Thanks in advance! CC: @Raffone17
@gmacario I reviewed the original PR https://github.com/chrvadala/node-ble/pull/53. If you prefer to continue here, we can close the old one and start from here.
@chrvadala we can continue from here.
That's fine, I'm going to close the other PR. Anyway, I commented your code there and I see that same requests apply here. Can you review your code? Thanks
Superseed by #67
Released with 1.11
Hello, it is the same PR #53 , but with added unit tests, as it was requested in the comment
Originally posted by @chrvadala in https://github.com/chrvadala/node-ble/pull/53#pullrequestreview-1284036695