search

chrvadala / node-ble

Bluetooth Low Energy (BLE) library written with pure Node.js (no bindings) - baked by Bluez via DBus
https://www.npmjs.com/package/node-ble
MIT License
310 stars 45 forks source link

Add function for get ManufacturerData and AdvertisingData with more tests #61

Closed maxsimych closed 4 months ago

maxsimych commented 1 year ago

Hello, it is the same PR #53 , but with added unit tests, as it was requested in the comment

          Hello, thanks for this useful PR. Can you integrate it with some unit tests.

Originally posted by @chrvadala in https://github.com/chrvadala/node-ble/pull/53#pullrequestreview-1284036695

gmacario commented 11 months ago

Hello @chrvadala,

Any chances to have this PR reviewed and possibly merged into your repo?

Thanks in advance! CC: @Raffone17

chrvadala commented 6 months ago

@gmacario I reviewed the original PR https://github.com/chrvadala/node-ble/pull/53. If you prefer to continue here, we can close the old one and start from here.

Raffone17 commented 6 months ago

@chrvadala we can continue from here.

chrvadala commented 6 months ago

That's fine, I'm going to close the other PR. Anyway, I commented your code there and I see that same requests apply here. Can you review your code? Thanks

chrvadala commented 4 months ago

Superseed by #67

chrvadala commented 3 months ago

Released with 1.11