search

chrvadala / react-svg-pan-zoom

:eyes: A React component that adds pan and zoom features to SVG
https://chrvadala.github.io/react-svg-pan-zoom/
MIT License
681 stars 127 forks source link

Question: deprecating the use of componentWillReceiveProps? #124

Closed lionkeng closed 5 years ago

lionkeng commented 5 years ago

Hello,

Are there plans to deprecate the use componentWillReceiveProps following the recommendations in React 16?

chrvadala commented 5 years ago

Hi @lionkeng, yes I plan to change this in the next major release, but actually I don't have a release date.

Some useful doc: https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops

lionkeng commented 5 years ago

@chrvadala happy to help out with the code refactoring. Just let me know.

chrvadala commented 5 years ago

Oh sure, any help is absolutely accepted. Would you like to work on a PR about this issue? At the same time probably you could work on this another issue https://github.com/chrvadala/react-svg-pan-zoom/issues/51, because you have to change almost the same parts. LMK

chrvadala commented 5 years ago

Done. Will be released with 3.0