chrvadala / react-svg-pan-zoom

:eyes: A React component that adds pan and zoom features to SVG
https://chrvadala.github.io/react-svg-pan-zoom/
MIT License
684 stars 126 forks source link

Typescript types missing for V3 #155

Closed gorgi closed 5 years ago

gorgi commented 5 years ago

Features:

Hi and thanks for this awesome library. Is there any plan for introducing types for version 3?

chrvadala commented 5 years ago

This should be what you are looking for https://www.npmjs.com/package/@types/react-svg-pan-zoom

gorgi commented 5 years ago

Thanks for replying @chrvadala .

Those types are for version 2. These migrations have not been implemented in the type definitions: https://github.com/chrvadala/react-svg-pan-zoom/blob/master/docs/migrate-from-v2-to-v3.md

As you can see here: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-svg-pan-zoom/index.d.ts

chrvadala commented 5 years ago

You're right... Sorry, but I don't use ts Can you try to contact https://github.com/huy-nguyen that is the maintenair of the ts descriptor?

huy-nguyen commented 5 years ago

I don't use the library anymore but nevertheless opened a PR here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/39085.

gorgi commented 5 years ago

That is great, thanks @huy-nguyen

chrvadala commented 5 years ago

Thanks @huy-nguyen 🚀