search

chrxh / alien

ALIEN is a CUDA-powered artificial life simulation program.
https://alien-project.org
BSD 3-Clause "New" or "Revised" License
3.48k stars 106 forks source link

Better zones UI #95

Open willjallen opened 3 months ago

willjallen commented 3 months ago

Addresses Name zones and Reorder zone tabs in #92

willjallen commented 3 months ago

Still a WIP. There's a bug during deserialization where opening unopened tabs makes them refresh and reorder.

chrxh commented 3 months ago

These are nice additions. Take your time and let me know when it's ready.

willjallen commented 2 months ago

@chrxh ready for review

willjallen commented 2 months ago
  • Analogous to the counting of the radiation sources (see radiation source window), I would prefer to name the zones from "Zone 1" (and not from Zone 0). Counting from 0 is not so familiar to many people (except for programmers :D)

Fair :)

Some minor stuff (need not necessarily be addressed in this PR, but it would be nice to fix them at some point):

  • The automatic naming scheme can create zone names which are already in use. An example: Given: 2 zones named "Zone 0" and "Zone 1" Action: delete "Zone 0" and than add a new zone. The new zone will become the name "Zone 1", which is already in use.

  • A reset button for the zone name, as is also available for all other properties.

  • The order of the zones are not preserved after saving and loading a sim.

  • When copying simulation parameters (by pressing the copy button), rearranging the zones and then pasting the parameters, the order of the zones is not restored.

Good observations. I will fix these.

Do you would like to see your feature in v4.9.2 or in v4.10.0 (this update will still take a few weeks until it will be ready)? Tomorrow I will be one week off so I can probably not answer until I return.

My regular work schedule is highly variable at the moment, but I do not think it will take weeks to make these changes. Enjoy your time off!

chrxh commented 2 months ago

My regular work schedule is highly variable at the moment, but I do not think it will take weeks to make these changes. Enjoy your time off!

Thanks! The part about the weeks referred to changes that I still want to make and had planned for v4.10. Your changes could then also be included in that version :)