chrys87 / fenrir

An TTY screenreader for Linux.
GNU Lesser General Public License v3.0
47 stars 13 forks source link

configure-pulseaudio script not actually installed #14

Closed sthibaul closed 6 years ago

sthibaul commented 6 years ago

Hello,

install.sh advises the user to use /usr/share/fenrir/tools/configure-pulseaudio , but this is actually not installed by install.sh

chrys87 commented 6 years ago

Howdy,

the following lines are copieng all tools (also configure-pulse.sh) install -m755 -d /usr/share/fenrir/tools cp -af tools/* /usr/share/fenrir/tools

could it be that you are using an old version of fenrir, where all that stuff was not fixed yet? i did a lot of bugfixing and feature work in the last couple of months.. i recomment installing current fenrir versions via setup.py thats the "offical" python way of love :).

sthibaul commented 6 years ago

I was looking at the latest releases 1.05 and 1.06

sthibaul commented 6 years ago

One usually looks at released versions, not what happens to be the tip of the development tree, which could be at an unknown stability state.

chrys87 commented 6 years ago

Howdy,

the latest release is fresh 1.5 (just 2 weeks old) not 1.0x. i create a tarball to reduce confusion (it was currently just living in git :), ) https://github.com/chrys87/fenrir/releases/tag/1.5.0

sthibaul commented 6 years ago

Just creating a tag in the git tree is not enough to make it known indeed. Thanks for the tarball, I'll package it.

chrys87 commented 6 years ago

I m sorry :), i try to improve myself in version management. Back to the problem: fixed in 1.5 branch right?

sthibaul commented 6 years ago

the tool is installed, yes, just not with the same name: install.sh talks about configure-pulseaudio, while the tool is called configure_pulse.sh

chrys87 commented 6 years ago

I changed the install.sh to print the correct scriptname "configure_pulse.sh" and did a bugfix release for you https://github.com/chrys87/fenrir/archive/1.5.1.tar.gz thanks testing + reporting :). any reported and fixed bug can only improve fenrirs quality.

chrys87 commented 6 years ago

is this fixed?

sthibaul commented 6 years ago

Yes it seems to be