chrys87 / fenrir

An TTY screenreader for Linux.
GNU Lesser General Public License v3.0
47 stars 13 forks source link

speechDriver/genericDriver.py: avoid the shell and stay safe. #19

Closed CMB closed 6 years ago

chrys87 commented 6 years ago

Howdy,

thanks for providing this important fix. I will take a look at this as soon as i will be at home. A small question about this:

CMB commented 6 years ago

i see you add the " -- " to the fallback (this is only used if the configuration is empty), should i also change this in the configuration files? line: genericSpeechCommand=espeak -a fenrirVolume -s fenrirRate -p fenrirPitch -v fenrirVoice "fenrirText" in config/settings/settings.conf config/settings/settings.conf.example config/settings/espeak.settings.conf config/settings/settings.conf.storm config/settings/speech-dispatcher.settings.conf

Yes it is needed there, too. Sorry for missing that.

-- Chris