search

chrysn / aiocoap

The Python CoAP library
Other
261 stars 119 forks source link

OSCORE block-wise is untested / erroneous #220

Open chrysn opened 3 years ago

chrysn commented 3 years ago

At least some part in the combination of the OSCORE transport and the oscore_sitewrapper is not handling block-wise correctly: It appears that inner block-wise is started, and then outer block-wise kicks in as the messages exceed 1024 bytes (which in itself is a bug as well, but at least shows that otherwise outer block-wise works).

Up to right now that was undetected because the plug tests don't include anything block-wise; the group mode running the regular tests exposed this (and has its block-wise test disabled).

chrysn commented 2 years ago

Group block tests are now enabled, and the fragmentation threshold is now increased (since 14f091e1f289f0fe009163e65d8181ccf2334fc7) to not cause outer-blockwise. It's still a bad workaround though (because the transport's total message size should be considered), and outer block-wise should be supported.