[feat]: Issue #14, Issue #9

chshersh / iris

🌈 Haskell CLI Framework supporting Command Line Interface Guidelines

https://hackage.haskell.org/package/iris

Mozilla Public License 2.0

176 stars 21 forks source link

[feat]: Issue #14, Issue #9 #73

Closed initial-mockingbird closed 1 year ago

initial-mockingbird commented 1 year ago

* Added Yes/No functions and multiple choice functions (Issue #9).
* Added a protected writefile function (Issue #14)

Possible improvements:

Move to ansi-terminal or other coloring library in order to manage colors in a more scalable way (currently ANSI Escape codes are used)
Passing a default value explicitly and a parsing function opens the possibility that their values differ. Think a way around this (maybe promoting to type level?)

chshersh commented 1 year ago

Hi @initial-mockingbird 👋🏻

Thanks for your contribution! Could you implement #14 in a separate PR to follow the "one PR per one issue" recommendation? Also, the decision on how to implement #9 is not yet made so it's too early to implement a take on this one 🙂

chshersh commented 1 year ago

I'm closing this PR because:

The solution to multiple-choice API is still under design and I imagine there's lots of work to be done before that
It would be better to implement #14 in a separate smaller PR to make things easier to review.

At the moment, I'm reviewing all the outstanding PR, so I can prepare the next 0.1.0.0 release of Iris 🙂

In any case, thanks a lot for your contribution during Hacktoberfest! 🙌🏻