Closed Dponya closed 1 year ago
@chshersh Hi! Are there some problems with PR or CI pipelines? I've checked building of Iris on several ghc versions that were included into build, everything goes fine locally. Should I fix something?
Hi @Dponya 👋🏻
Sorry, I haven't reviewed this PR yet. I've been very busy with personal stuff and tons of other PRs during Hacktoberfest 🥴
From CI logs, I can see that the markdown-unlit
preprocessor is not configured properly. You need to add it to the build-tool-depends
section instead of build-depends
to make it work on a newer Cabal. See an example here:
The tutorial looks great! There's always room for improvement but I left a few main suggestions on how to improve the docs slightly_smiling_face
And see my comment before on fixing CI.
Thanks! Truly talk, I was unsatisfied with the quality of the documentation. So, I took look at the co-log
example and was inspired by those tutorial's structure. Unfortunately, I delivered updates while you taking a review on PR. :sweat_smile:
So, I pushed new fixes that maybe fit the above proposals.
Resolves #16
Well. It seems like that my current implementation have problems with requirement in issue:
lines numbers to stderr and with lines to stdout (to mimic the output of ripgrep)
I've seen a
ripgrep
and implemented it like that:And in this function I used
putStr
for output like that:Where the line number is putted right after
Iris.putStdoutColouredLn
output. Maybe it breaks requirements withstderr
andstdout
, if it is, how to avoid it? I really don't have an idea to implement it in another way to include using Colourista to print it the right way with colors.And I'm sure that the documentation in
examples/simple-grep/README.md
has serious problems with explanation, if it is, please leave in the comments proposals to fix it.Thanks you!