chshersh / iris

🌈 Haskell CLI Framework supporting Command Line Interface Guidelines
https://hackage.haskell.org/package/iris
Mozilla Public License 2.0
173 stars 21 forks source link

[#89] Add 'putStdoutColoured' and 'putStderrColoured' #92

Closed Dponya closed 1 year ago

Dponya commented 1 year ago

Resolves #89

Additional tasks

chshersh commented 1 year ago

Hi @Dponya 👋🏻

I see that @lillycat332 already opened a PR to resolve the same issue but they were slightly faster 😅

I still accept your contribution so it should be accepted for Hacktoberfest nevertheless 👍🏻

Dponya commented 1 year ago

Hi @Dponya 👋🏻

I see that @lillycat332 already opened a PR to resolve the same issue but they were slightly faster sweat_smile

* [#90 - Changes types in 'Iris.Colour.Formatting' from 'ByteString' to 'Text' #91](https://github.com/chshersh/iris/pull/91)

I still accept your contribution so it should be accepted for Hacktoberfest nevertheless 👍🏻 @chshersh hey :wave:

Oh, oops. Sorry for that, I thought there is two independent issues #90 and #89. One for replacing ByteString to Text, another for output issue in #87. If @lillycat332's PR solves problem with #87, should I close this PR?

chshersh commented 1 year ago

@Dponya My bad 🙏🏻 Indeed, I confused two issues 😮‍💨

In that case, I see no problem and no conflict! 👌🏻

Dponya commented 1 year ago

Thanks, looks great!

I have only minor suggestions. Also, could you please add your changes to the CHANGELOG in the [unreleased] section? 🙏🏻

Should I add #89 only or #16 too to the CHANGELOG?

chshersh commented 1 year ago

@Dponya You can add #16 to the changelog as well 👍🏻 You can also use these new functions in the simple-grep tutorial (and update the tutorial output as well)