Closed Dponya closed 1 year ago
Hi @Dponya 👋🏻
I see that @lillycat332 already opened a PR to resolve the same issue but they were slightly faster 😅
I still accept your contribution so it should be accepted for Hacktoberfest nevertheless 👍🏻
Hi @Dponya 👋🏻
I see that @lillycat332 already opened a PR to resolve the same issue but they were slightly faster sweat_smile
* [#90 - Changes types in 'Iris.Colour.Formatting' from 'ByteString' to 'Text' #91](https://github.com/chshersh/iris/pull/91)
I still accept your contribution so it should be accepted for Hacktoberfest nevertheless 👍🏻 @chshersh hey :wave:
Oh, oops. Sorry for that, I thought there is two independent issues #90 and #89. One for replacing ByteString
to Text
, another for output issue in #87. If @lillycat332's PR solves problem with #87, should I close this PR?
@Dponya My bad 🙏🏻 Indeed, I confused two issues 😮💨
In that case, I see no problem and no conflict! 👌🏻
Thanks, looks great!
I have only minor suggestions. Also, could you please add your changes to the CHANGELOG in the
[unreleased]
section? 🙏🏻
Should I add #89 only or #16 too to the CHANGELOG?
@Dponya You can add #16 to the changelog as well 👍🏻
You can also use these new functions in the simple-grep
tutorial (and update the tutorial output as well)
Resolves #89
Additional tasks