chshersh / iris

🌈 Haskell CLI Framework supporting Command Line Interface Guidelines
https://hackage.haskell.org/package/iris
Mozilla Public License 2.0
173 stars 21 forks source link

Resolves [#22] Add CLI options to handle colouring #93

Closed marcellourbani closed 1 year ago

marcellourbani commented 1 year ago

Resolves #22

I had to change expectations of some tests in cliSpecParserConflicts to account for the new options, I wonde if they can be made more robust

Also, I guess I should also have added tests for conflicts of --no-colour and friends. Didn't feel like doing that today, and I'll be on holiday next week, so I thought was good enough for now

Additional tasks

chshersh commented 1 year ago

Hey @marcellourbani 👋🏻

Sorry for the delay in review. This PR is a lot of work and will take a while for me to review 😅

marcellourbani commented 1 year ago

No worries, I'm on holiday with no laptop anyway

On Wed, 19 Oct 2022, 13:26 Dmitrii Kovanikov, @.***> wrote:

Hey @marcellourbani https://github.com/marcellourbani 👋🏻

Sorry for the delay in review. This PR is a lot of work and will take a while for me to review 😅

— Reply to this email directly, view it on GitHub https://github.com/chshersh/iris/pull/93#issuecomment-1283856868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASW6HMAU742OZRUMV3MSCLWD7LIDANCNFSM6AAAAAARGMGTNQ . You are receiving this because you were mentioned.Message ID: @.***>

marcellourbani commented 1 year ago

Thanks @chshersh .I'm quite interested and will look into all of these, on my own time. Probably later this week Cheers Marcello

marcellourbani commented 1 year ago

Sorted all except the ColourOption constructors